[webkit-reviews] review requested: [Bug 42759] Always freeing m_logAttrs in TextBreakIteratorGtk.cpp: setUpIterator() : [Attachment 92237] m_logAttrs freed when necessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 07:18:19 PDT 2011


Peter Hatina <phatina at redhat.com> has asked  for review:
Bug 42759: Always freeing m_logAttrs in TextBreakIteratorGtk.cpp:
setUpIterator()
https://bugs.webkit.org/show_bug.cgi?id=42759

Attachment 92237: m_logAttrs freed when necessary
https://bugs.webkit.org/attachment.cgi?id=92237&action=review

------- Additional Comments from Peter Hatina <phatina at redhat.com>
Wrt motivation: When breaking the text, I think, it is not always necessary to
reallocate the memory block, if it is sufficient for future use. Also we save
mem. allocation call and part of zero-ing proces, which is done only on the
part of the portion. To my mind, it is also cheaper to use once-prepared block,
than always release it and call for another one.

Wrt coding style: now it should be fine.


More information about the webkit-reviews mailing list