[webkit-reviews] review requested: [Bug 51106] [Qt] Implement the fast font path for Qt : [Attachment 92225] Proposed patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 06:06:43 PDT 2011


Andreas Kling <kling at webkit.org> has asked  for review:
Bug 51106: [Qt] Implement the fast font path for Qt
https://bugs.webkit.org/show_bug.cgi?id=51106

Attachment 92225: Proposed patch v4
https://bugs.webkit.org/attachment.cgi?id=92225&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Updated patch after IRL review with Simon.
Renamed HAVE(QGLYPHS) to HAVE(QRAWFONT) for inexplicable aesthetic reasons.
The GlyphPage::fill() friend hack is removed in favor of implementing
SimpleFontData::platformWidthForGlyph().
As a side-effect, advances for zero-size fonts are now 0 (as they should be.)
I have requested an API to disable unneeded caching in Qt's font engines, but
this is not yet available, and will be used in a follow-up patch.


More information about the webkit-reviews mailing list