[webkit-reviews] review canceled: [Bug 58420] String operator+ reallocates unnecessarily when concatting > 2 strings : [Attachment 92201] Patch v14

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 04:20:38 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has canceled Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 58420: String operator+ reallocates unnecessarily when concatting > 2
strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Attachment 92201: Patch v14
https://bugs.webkit.org/attachment.cgi?id=92201&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Additionally supply "StringAppend<const char*, AtomicString> operator+(const
char* string1, const AtomicString& string2)", exposed by editing/markup.cpp (Qt
build failure).
Even with that fix win won't build properly, there's still a cyclic include
problem, to be investigated.


More information about the webkit-reviews mailing list