[webkit-reviews] review granted: [Bug 60087] WK2 Icon Database should provide access to all image representations in the icon. : [Attachment 92174] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 3 17:24:30 PDT 2011
Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 60087: WK2 Icon Database should provide access to all image representations
in the icon.
https://bugs.webkit.org/show_bug.cgi?id=60087
Attachment 92174: Patch v1
https://bugs.webkit.org/attachment.cgi?id=92174&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92174&action=review
> Source/WebCore/platform/graphics/BitmapImage.h:145
> + virtual RetainPtr<CFArrayRef> getCGImageArray();
I am not sure if get here is necessary, since you are returning a RetainPtr.
More information about the webkit-reviews
mailing list