[webkit-reviews] review granted: [Bug 60063] Update rebaseline queue server to handle hierarchical test results : [Attachment 92130] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 60063: Update rebaseline queue server to handle hierarchical test results
https://bugs.webkit.org/show_bug.cgi?id=60063

Attachment 92130: Patch
https://bugs.webkit.org/attachment.cgi?id=92130&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92130&action=review

Whoops. Sorry. I thought I found all the places that read in the results.

> Tools/RebaselineQueueServer/templates/builder-queue-edit.html:59
> +    console.dir(results);

Did you mean to leave this in?

> Tools/RebaselineQueueServer/templates/builder-queue-edit.html:72
> +	   if (actual != expected &&
> +	       expected.split(' ').indexOf(actual) == -1 &&
> +	       actual != 'SKIP' &&
> +	       actual.indexOf('PASS') == -1 &&
> +	       (expected.indexOf('FAIL') == -1 || actual.indexOf('TIMEOUT') !=
-1)) {
> +	     results.name = test;

nit: i prefer the old code if you changed the continue to an early return. But
your call.