[webkit-reviews] review granted: [Bug 59143] Need populate touch-icon url to FrameLoaderClient : [Attachment 92149] Address the comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 3 16:11:43 PDT 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted
michaelbai at chromium.org's request for review:
Bug 59143: Need populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Attachment 92149: Address the comments
https://bugs.webkit.org/attachment.cgi?id=92149&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92149&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   Respect the interface change in FrameLoaderClient.

This comment doesn't make any sense.  Just remove it.

> Source/WebCore/dom/IconURL.h:67
> +typedef Vector<IconURL, ICON_COUNT> IconURLs;

Nice!


More information about the webkit-reviews mailing list