[webkit-reviews] review denied: [Bug 60066] [chromium] Go through WebPermissionClient for local storage access. Also cleanup left over code from previous WebPermissionClient change. : [Attachment 92137] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 60066: [chromium] Go through WebPermissionClient for local storage access. 
Also cleanup left over code from previous WebPermissionClient change.
https://bugs.webkit.org/show_bug.cgi?id=60066

Attachment 92137: Patch
https://bugs.webkit.org/attachment.cgi?id=92137&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92137&action=review

> Source/WebKit/chromium/public/WebPermissionClient.h:49
> +    virtual bool allowLocalStorage(WebFrame*, const WebURL&) { return true;
}

the URL can be generated from the WebFrame, so it's redundant here

> Source/WebKit/chromium/src/StorageAreaProxy.cpp:89
> +    if (webView->permissionClient()
> +	   && !webView->permissionClient()->allowLocalStorage(webFrame, url)) {


nit: don't line wrap this