[webkit-reviews] review granted: [Bug 60044] Extract LineInfo class : [Attachment 92117] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 3 13:44:44 PDT 2011
Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 60044: Extract LineInfo class
https://bugs.webkit.org/show_bug.cgi?id=60044
Attachment 92117: Patch
https://bugs.webkit.org/attachment.cgi?id=92117&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92117&action=review
LGTM.
> Source/WebCore/rendering/RenderBlockLineLayout.cpp:80
> + void setPreviousLineBrokeCleanly(bool previousLineBrokeCleanly) {
m_previousLineBrokeCleanly = previousLineBrokeCleanly; }
I used to think we normally put a \n before private. But since thsi is the 3rd
time I've made ethis comment today, I think my sense may be off. :)
More information about the webkit-reviews
mailing list