[webkit-reviews] review granted: [Bug 60048] store results.html options in localstorage : [Attachment 92098] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 60048: store results.html options in localstorage
https://bugs.webkit.org/show_bug.cgi?id=60048

Attachment 92098: Patch
https://bugs.webkit.org/attachment.cgi?id=92098&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92098&action=review

>>> LayoutTests/fast/harness/resources/results-test.js:65

>> 
>> opt_?  Funny prefix.
> 
> It's a convention I picked up from Google's JS code. I'm happy to remove the
prefix or do something different. It's useful to be able to specify that an
argument is optional though.

The opt_ prefix seems fine considering we already checked in some code for it. 
We can discuss/change if we decide to have a JS style guide.