[webkit-reviews] review granted: [Bug 60046] Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class : [Attachment 92097] cleanup

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 60046: Bundle trailingSpaceObject and trailingPositionedBoxes in
findNextLineBreak as a class
https://bugs.webkit.org/show_bug.cgi?id=60046

Attachment 92097: cleanup
https://bugs.webkit.org/attachment.cgi?id=92097&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92097&action=review

>>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2297
>>> +	 trailingObjects.addMidpoints(lineMidpointState, lBreak);
>> 
>> Maybe addMidpoints needs a better name.  Are we adding midpoints to the
TrailingObjects?  Or are we adding midpoints based on the trailing objects? 
Should this be on MidPointSTate or on the TrailingObjects class?
> 
> Does updateMidpoints sound better?

Try updateMidpointsForTrailingBoxes.