[webkit-reviews] review granted: [Bug 60045] Scrollbar thumb sometimes leaves artifacts in the track after scrolling : [Attachment 92094] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 3 11:38:00 PDT 2011


mitz at webkit.org has granted Beth Dakin <bdakin at apple.com>'s request for review:
Bug 60045: Scrollbar thumb sometimes leaves artifacts in the track after
scrolling
https://bugs.webkit.org/show_bug.cgi?id=60045

Attachment 92094: Patch
https://bugs.webkit.org/attachment.cgi?id=92094&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=92094&action=review

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:143
> +#if USE(WK_SCROLLBAR_PAINTER)
> +    gButtonPlacement = ScrollbarButtonsNone;
> +#else

You can return here and not read the default. Or you can return without even
setting the value because it’s already initialized to ScrollbarButtonsNone in
the static initializer.


More information about the webkit-reviews mailing list