[webkit-reviews] review requested: [Bug 42759] Always freeing m_logAttrs in TextBreakIteratorGtk.cpp: setUpIterator() : [Attachment 92060] m_logAttrs freed when necessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 3 04:09:37 PDT 2011


Peter Hatina <phatina at redhat.com> has asked  for review:
Bug 42759: Always freeing m_logAttrs in TextBreakIteratorGtk.cpp:
setUpIterator()
https://bugs.webkit.org/show_bug.cgi?id=42759

Attachment 92060: m_logAttrs freed when necessary
https://bugs.webkit.org/attachment.cgi?id=92060&action=review

------- Additional Comments from Peter Hatina <phatina at redhat.com>
In the static function setUpIterator(...), the iterator public member
m_logAttrs is freed and reallocated, when its length isn't sufficient for the
proposed string. Otherwise, no allocation + deallocation is called and we can
use part of the former array m_logAttrs.


More information about the webkit-reviews mailing list