[webkit-reviews] review requested: [Bug 59845] Implement FULLSCREEN_API on Windows, Part 3: WebKit2 : [Attachment 92052] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 3 00:18:19 PDT 2011
Jer Noble <jer.noble at apple.com> has asked for review:
Bug 59845: Implement FULLSCREEN_API on Windows, Part 3: WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59845
Attachment 92052: Patch
https://bugs.webkit.org/attachment.cgi?id=92052&action=review
------- Additional Comments from Jer Noble <jer.noble at apple.com>
Addressed (most of) Adam's comments. Found out I was misinterpreting how
::AnimateWindow() works. (Hint: it's synchronous.) Also, it requires windows
to respond to the WM_PAINTCLIENT command, so that's been added to
MediaPlayerPrivateFullScreenWindow class.
More information about the webkit-reviews
mailing list