[webkit-reviews] review granted: [Bug 59963] fix failing printing_unittest on win32 : [Attachment 91982] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 59963: fix failing printing_unittest on win32
https://bugs.webkit.org/show_bug.cgi?id=59963

Attachment 91982: Patch
https://bugs.webkit.org/attachment.cgi?id=91982&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91982&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:588
> -	   # FIXME: scm.py outputs debug logging to stderr. It should probably
go to stdout.
> -	   self.assertFalse(err.empty())
> +	   # FIXME: debug output from the port and scm objects may or may not
go
> +	   # to stderr, so there's no point in testing its contents here.
> +	   # self.assertTrue(err.empty())

Generally we don't want commented out code.  Maybe just remove it?