[webkit-reviews] review granted: [Bug 59978] add image toggling behavior from old-run-webkit-tests : [Attachment 92006] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 59978: add image toggling behavior from old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=59978

Attachment 92006: Patch
https://bugs.webkit.org/attachment.cgi?id=92006&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92006&action=review

> LayoutTests/fast/harness/resources/results-test.js:114
> +{	

Nit: trailing whitespace

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:251
> +""" % (self._testname, self.output_filename('-diff.png'),
self.output_filename(''))
> +	   self._port._filesystem.write_binary_file(diffs_html_filename, html)

Nit: When I have lots of replacement params, I normally switch to the named
placeholders.