[webkit-reviews] review granted: [Bug 59070] [Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method : [Attachment 91988] patch v4 (second take), use the fact that synchronous loads are always finished

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Caio Marcelo de Oliveira Filho
<caio.oliveira at openbossa.org>'s request for review:
Bug 59070: [Qt] Fix QNetworkReplyWrapper to not depend on
QNetworkReply::isFinished() method
https://bugs.webkit.org/show_bug.cgi?id=59070

Attachment 91988: patch v4 (second take), use the fact that synchronous loads
are always finished
https://bugs.webkit.org/attachment.cgi?id=91988&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91988&action=review

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:311
> +    // QNetworkReply, the QNetworkReply::isFinished() is never true, so we
need to keep track

s/the//

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:312
> +    // ourselves. This limitation is fixed in 4.8, but we'll still have
applications that doesn't

s/doesn't/don't/