[webkit-reviews] review requested: [Bug 59951] Implement Date and Time Input Value Sanitization : [Attachment 91997] [PATCH] Add Date+Time Value Sanitization

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 2 16:03:46 PDT 2011


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 59951: Implement Date and Time Input Value Sanitization
https://bugs.webkit.org/show_bug.cgi?id=59951

Attachment 91997: [PATCH] Add Date+Time Value Sanitization
https://bugs.webkit.org/attachment.cgi?id=91997&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
I decided sanitizeValue should actually sanitize HTML5 values,
and not include localized dates as valid. It makes no send
for a page to do elem.value = 'today' and have it actually work.

This also includes some JavaScript cleanup to the last patch.
Darin, are you okay with the change?

I will be filing a separate bug on improving ValidityState::valid,
which accesses input->value() 7 times, each of which might
re-sanitize the value without caching. Seems like there should
be some improvements there.


More information about the webkit-reviews mailing list