[webkit-reviews] review granted: [Bug 59825] Respect fixed text-indent on ::-webkit-input-placeholder : [Attachment 91793] [PATCH] Handle fixed text-indent for placeholders (tests rtl)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 2 14:46:43 PDT 2011
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 59825: Respect fixed text-indent on ::-webkit-input-placeholder
https://bugs.webkit.org/show_bug.cgi?id=59825
Attachment 91793: [PATCH] Handle fixed text-indent for placeholders (tests rtl)
https://bugs.webkit.org/attachment.cgi?id=91793&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91793&action=review
r=me with the typo fixed.
> Source/WebCore/rendering/RenderTextControl.cpp:645
> + int styleTextIdent = placeholderStyle->textIndent().isFixed() ?
placeholderStyle->textIndent().calcMinValue(0) : 0;
Typo? "Ident" -> "Indent"
More information about the webkit-reviews
mailing list