[webkit-reviews] review granted: [Bug 59124] WebKit2 thinks the web process is unresponsive when a plugin displays a context menu : [Attachment 91950] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 2 12:02:04 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Jeff Miller
<jeffm at apple.com>'s request for review:
Bug 59124: WebKit2 thinks the web process is unresponsive when a plugin
displays a context menu
https://bugs.webkit.org/show_bug.cgi?id=59124

Attachment 91950: Patch
https://bugs.webkit.org/attachment.cgi?id=91950&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91950&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:2660
> +void WebPageProxy::stopResponsivenessTimer()
> +{
> +    // If we're sending an event to a plug-in, we can't control how long the
plug-in
> +    // takes to process it (e.g. it may display a context menu), so we stop
the
> +    // responsiveness timer in this case.
> +    process()->responsivenessTimer()->stop();
> +}

This comment doesn't seem appropriate here. I think you can just leave it out.
The function is pretty self-explanatory.


More information about the webkit-reviews mailing list