[webkit-reviews] review denied: [Bug 56375] [Qt] PageGroup::closeLocalStorage() should be called when the app quits : [Attachment 91943] Close Local Storage when last QWebPage is destroyed.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 2 11:29:36 PDT 2011
Antonio Gomes <tonikitoo at webkit.org> has denied Joe Wild
<joseph.wild at nokia.com>'s request for review:
Bug 56375: [Qt] PageGroup::closeLocalStorage() should be called when the app
quits
https://bugs.webkit.org/show_bug.cgi?id=56375
Attachment 91943: Close Local Storage when last QWebPage is destroyed.
https://bugs.webkit.org/attachment.cgi?id=91943&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91943&action=review
> Source/WebKit/qt/Api/qwebpage.cpp:393
> + // if destroying last WebPage instance. Release resources.
// If destroying last WebPage instance, release resources.
> Source/WebKit/qt/Api/qwebpage.cpp:394
> + if (instanceCount <= 0)
How can it be less than 0?
> Source/WebKit/qt/Api/qwebpage_p.h:214
> + static int instanceCount; // Used to clean up when last instance
destroyed.
unneeded two spaces.
More information about the webkit-reviews
mailing list