[webkit-reviews] review granted: [Bug 59923] EWS should report the list of unexpected failures : [Attachment 91902] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 59923: EWS should report the list of unexpected failures
https://bugs.webkit.org/show_bug.cgi?id=59923

Attachment 91902: Patch
https://bugs.webkit.org/attachment.cgi?id=91902&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91902&action=review

> Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:447
> +	   task = self._run_through_task(commit_queue, expected_stderr,
ScriptError)
> +	  
self.assertEqual(task.results_from_patch_test_run(task._patch).failing_tests(),
["foo.html", "bar.html"])

Seems to support the case that this should be moved onto a custom Exception.