[webkit-reviews] review denied: [Bug 59071] <input type="number"> dispatches two blurs when tabbing from an invalid number : [Attachment 91927] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 2 09:41:43 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 59071: <input type="number"> dispatches two blurs when tabbing from an
invalid number
https://bugs.webkit.org/show_bug.cgi?id=59071

Attachment 91927: Patch
https://bugs.webkit.org/attachment.cgi?id=91927&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91927&action=review

We really should take a deeper look at the whole blur/focus event firing
lifecycle. I noticed that dispatchBlurEvent is actually performing some of the
"do stuff before blur event is dispatched" things.

> Source/WebCore/dom/Node.h:553
> +    virtual void beforeBlurEvent();

I think a more common convention is to use the "will" prefix, as in "willBlur".


More information about the webkit-reviews mailing list