[webkit-reviews] review granted: [Bug 59920] Add base case for a test-running EWS : [Attachment 91891] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 59920: Add base case for a test-running EWS
https://bugs.webkit.org/show_bug.cgi?id=59920

Attachment 91891: Patch
https://bugs.webkit.org/attachment.cgi?id=91891&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91891&action=review

This seems OK except for the hard-coded results.html blob in your layout tests.
 See if you can't inject a mock somewhere instead please. :)

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:116
> +	   # FIXME: This violations abstraction

englishes this not

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:168
> +    def refetch_patch(self, patch):
> +	   return self._tool.bugs.fetch_attachment(patch.id())

Seems shared, no?

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:142
> +	  
tool.filesystem.write_text_file("/tmp/layout-test-results/results.html",
self._example_results_html)

Can't we inject a LayoutTestResults instead somewhere?