[webkit-reviews] review requested: [Bug 51099] [Qt] QWebPagePrivate::inputMethodEvent has problem when compositing Korean : [Attachment 91874] Patch

[bugzilla-daemon at webkit.org]

Hwang <luxtella at company100.net> has asked  for review:
Bug 51099: [Qt] QWebPagePrivate::inputMethodEvent has problem when compositing
Korean
https://bugs.webkit.org/show_bug.cgi?id=51099

Attachment 91874: Patch
https://bugs.webkit.org/attachment.cgi?id=91874&action=review

------- Additional Comments from Hwang <luxtella at company100.net>
This patch is about the caret disappearing.
I give up patching about the caret position on composition because when I patch
I have no confidence whether the other language have valid caret position.
If I have confidence I will patch again.

Although I find the way how to test, I can not find the feasible test way.
It is because
1. There is no JSObject API whether the caret is visible for layout test.
2. textInputController.setMarkedText's event is different from actual input
method event.

In detail about #2, the QInputMethodEvent instance that
QWebPagePrivate::inputMethodEvent method receives includes two attribute types
such as QInputMethodEvent::TextFormat and QInputMethodEvent::Cursor.
However, textInputController.setMarkedText(,,) only create
QInputMethodEvent::TextFormat type QInputMethodEvent instance.
I don't know it is Qt specific or not.