[webkit-reviews] review denied: [Bug 56274] Delegate some read-only DOM properties to FrameLoaderClient and ChromeClient : [Attachment 85705] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 1 12:36:00 PDT 2011


Eric Seidel <eric at webkit.org> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 56274: Delegate some read-only DOM properties to FrameLoaderClient and
ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=56274

Attachment 85705: Patch
https://bugs.webkit.org/attachment.cgi?id=85705&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I really don't like this design.

I think we should have a new AntiFingerprinting class or something that we can
optionally pass these values to and have it reply with lies.

I don't want to plumb all of these up through the client in every different
callsite.  Instead, it would be better to plumb through this lier class, which
can plumb through the client on ports which care.  Then all the
anti-fingerprinting logic can be implemented inside WebCore too.


More information about the webkit-reviews mailing list