[webkit-reviews] review granted: [Bug 59884] Move scm.py into its own module in preparation for splitting it up : [Attachment 91833] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 1 12:19:35 PDT 2011


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 59884: Move scm.py into its own module in preparation for splitting it up
https://bugs.webkit.org/show_bug.cgi?id=59884

Attachment 91833: Patch
https://bugs.webkit.org/attachment.cgi?id=91833&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91833&action=review

> Tools/Scripts/webkitpy/test/main.py:153
> +	   # unittest.main has horrible error reporting when module imports are
bad
> +	   # so we test import here to make debugging bad imports much easier.
> +	   for module in modules:
> +	       __import__(module)

Is this related?


More information about the webkit-reviews mailing list