[webkit-reviews] review granted: [Bug 58448] [Qt] Implement initial support to DataTransferItems : [Attachment 91712] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 1 10:43:34 PDT 2011
Eric Seidel <eric at webkit.org> has granted Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 58448: [Qt] Implement initial support to DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58448
Attachment 91712: Patch
https://bugs.webkit.org/attachment.cgi?id=91712&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91712&action=review
Looks reasonable.
> Source/WebCore/platform/qt/DataTransferItemQt.cpp:103
> + QByteArray rawData = mimeData->data(type());
> + data = QTextCodec::codecForName("UTF-16")->toUnicode(rawData);
I would have probably just written this as one line, but this is fine too.
More information about the webkit-reviews
mailing list