[webkit-reviews] review granted: [Bug 59837] Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent : [Attachment 91758] Fixed test failures
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 1 09:58:05 PDT 2011
Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 59837: Get rid of versions of sendContextMenuEvent and eventMayStartDrag
that takes NSEvent
https://bugs.webkit.org/show_bug.cgi?id=59837
Attachment 91758: Fixed test failures
https://bugs.webkit.org/attachment.cgi?id=91758&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91758&action=review
SGTM.
> Source/WebKit/mac/WebView/WebHTMLView.mm:3456
> + if (Page* page = coreFrame->page())
> + result =
coreFrame->eventHandler()->eventMayStartDrag(PlatformMouseEvent(event,
page->chrome()->platformPageClient()));
Will results still end up as false in the !page() case after this change?
More information about the webkit-reviews
mailing list