[webkit-reviews] review requested: [Bug 58420] String operator+ reallocates unnecessarily when concatting > 2 strings : [Attachment 91821] Patch v10

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 1 06:15:24 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 58420: String operator+ reallocates unnecessarily when concatting > 2
strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Attachment 91821: Patch v10
https://bugs.webkit.org/attachment.cgi?id=91821&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
A new approach, using Gavins recursive template idea, works like a charme, and
looks more beautiful than the first approach.
Builds fine on my mac, from scratch, no regressions in the layout tests.


More information about the webkit-reviews mailing list