[webkit-reviews] review requested: [Bug 58127] Web Inspector: missing fields in HAR : [Attachment 91816] Patch with passing tests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 1 02:19:21 PDT 2011


Mike West <mkwst at chromium.org> has asked  for review:
Bug 58127: Web Inspector: missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127

Attachment 91816: Patch with passing tests.
https://bugs.webkit.org/attachment.cgi?id=91816&action=review

------- Additional Comments from Mike West <mkwst at chromium.org>
This patch hard-codes "HTTP/1.1" in the response/request header text if it
isn't already present. It feels hacky, I'd love a better solution, but this
looks like the best we've got if the network stack doesn't include the
information for whatever reason. It also incorporates the remaining feedback
regarding `bodySize` and does a little bit of cleanup in `Resource.js`
(dropping line-ending whitespace, and adding a semicolon, nothing big...).


More information about the webkit-reviews mailing list