[webkit-reviews] review granted: [Bug 57481] [chromium] update the rebaseline tool to know about pngs with checksums : [Attachment 87764] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 57481: [chromium] update the rebaseline tool to know about pngs with
checksums
https://bugs.webkit.org/show_bug.cgi?id=57481

Attachment 87764: Patch
https://bugs.webkit.org/attachment.cgi?id=87764&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87764&action=review

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:429
> +    def _png_has_same_checksum(self, temp_name, checksum_expected_fullpath):


I know this is from the calling code, but temp_name is not the most clear
variable name. temp_file_name? temp_file_path?

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:435
> +	       return False

Maybe log an error here as well? If a checksum file exists, it's an error that
an associated png file doesn't, right?