[webkit-reviews] review canceled: [Bug 49111] [RTL] Arabic/AB - after typing a date, cursors doesn't go back : [Attachment 87749] fixed warning

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 49111: [RTL] Arabic/AB - after typing a date, cursors doesn't go back
https://bugs.webkit.org/show_bug.cgi?id=49111

Attachment 87749: fixed warning
https://bugs.webkit.org/attachment.cgi?id=87749&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87749&action=review

> Source/WebCore/editing/VisiblePosition.cpp:205
> +		       if (primaryDirection == LTR)
> +			   boxWithMinimumOffsetOnSameLine(box, offset);
> +		       else
> +			   boxWithMaximumOffsetOnSameLine(box, offset);

Ugh... this change is wrong.