[webkit-reviews] review denied: [Bug 54623] RTL web content should have left-hand scrollbar. : [Attachment 87748] A trial change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 13:57:10 PDT 2011


Dave Hyatt <hyatt at apple.com> has denied Hironori Bono <hbono at chromium.org>'s
request for review:
Bug 54623: RTL web content should have left-hand scrollbar.
https://bugs.webkit.org/show_bug.cgi?id=54623

Attachment 87748: A trial change
https://bugs.webkit.org/attachment.cgi?id=87748&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87748&action=review

Minusing because of the use of a CSS property (and for the other reasons
mentioned in the previous comment).

Not all platforms are going to want this change, so I think this is better off
as a Setting if you're going to do it.

> Source/WebCore/rendering/RenderBlock.cpp:1415
> +	       if (style()->isShowScrollbarOnLeft())

This is bad terminology and bad English.


More information about the webkit-reviews mailing list