[webkit-reviews] review granted: [Bug 57371] Accelerated path drawing could be faster : [Attachment 87755] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 57371: Accelerated path drawing could be faster
https://bugs.webkit.org/show_bug.cgi?id=57371

Attachment 87755: Patch
https://bugs.webkit.org/attachment.cgi?id=87755&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87755&action=review

Looks good. A couple of minor style issues, can fix upon landing.

> Source/WebCore/platform/graphics/chromium/GLES2Canvas.cpp:559
>      for (int i = 0; i < pathTesselation; ++i, t += tIncrement) {

Style nit: now that the body is one line, no braces.

> Source/WebCore/platform/graphics/chromium/GLES2Canvas.cpp:568
>      for (int i = 0; i < pathTesselation; ++i, t += tIncrement) {

No braces.

> Source/WebCore/platform/graphics/gpu/LoopBlinnMathUtils.cpp:640
> +	   second = third;     /* Remember ptr to current point. */ \
> +	   dprev = dcur;       /* Remember current delta. */	    \

What are these '\'s doing at the end of these lines?

> Source/WebCore/platform/graphics/gpu/LoopBlinnMathUtils.cpp:650
> +	   second = third;     /* Remember ptr to current point. */ \
> +	   dprev = dcur;       /* Remember current delta. */	    \

Same here.