[webkit-reviews] review denied: [Bug 42529] [Qt] Qt WebKit updates view on HTTP 204 response : [Attachment 87763] patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Luiz Agostini
<luiz at webkit.org>'s request for review:
Bug 42529: [Qt] Qt WebKit updates view on HTTP 204 response
https://bugs.webkit.org/show_bug.cgi?id=42529

Attachment 87763: patch
https://bugs.webkit.org/attachment.cgi?id=87763&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87763&action=review

A test would be nice.

> Source/WebKit/qt/ChangeLog:8
> +	   Ignoring http responses which have status code equal to 204 or 205.

I suggest to give the code name in the changelog so people don't have to look
by themself what are those code for.

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1184
> +    if (statusCode == 204 || statusCode == 205) {
> +	   // FIXME: a 205 response requires that the requester reset the
document view.

Shouldn't 205 just be ignored then so the view is reloaded?

Call me crazy but what about?:
enum {
   HttpStatusNoContent = 204
}
...
if (statusCode == HttpStatusNoContent, etc)