[webkit-reviews] review granted: [Bug 57560] WKCACFViewLayerTreeHost needs to tell WKCACFView where to render : [Attachment 87758] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 10:36:00 PDT 2011


Darin Adler <darin at apple.com> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 57560: WKCACFViewLayerTreeHost needs to tell WKCACFView where to render
https://bugs.webkit.org/show_bug.cgi?id=57560

Attachment 87758: Patch
https://bugs.webkit.org/attachment.cgi?id=87758&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87758&action=review

> Source/WebCore/ChangeLog:7
> +	   Fixes <http://webkit.org/b/57560> WKCACFViewLayerTreeHost needs to
tell WKCACFView where to

We need to teach the style checker about this alternate format for bug URLs.

> Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:47
> +    kWKCACFViewDrawingDestinationWindow = 0,
> +    kWKCACFViewDrawingDestinationImage = 1,

Do we really need to set these values explicitly.


More information about the webkit-reviews mailing list