[webkit-reviews] review granted: [Bug 57234] [GTK] Use glib API instead of fork + execl in ProcessLauncherGtk : [Attachment 87688] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 09:52:49 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 57234: [GTK] Use glib API instead of fork + execl in ProcessLauncherGtk
https://bugs.webkit.org/show_bug.cgi?id=57234

Attachment 87688: Updated patch
https://bugs.webkit.org/attachment.cgi?id=87688&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87688&action=review

Great stuff.

> Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:48
> +static void childSetupFunc(gpointer userData)

Perhaps rename this to childSetupFunction or childSetupCallback.


More information about the webkit-reviews mailing list