[webkit-reviews] review requested: [Bug 57515] [Mac] [WK2] Implement KeyDown function for WebKit2 EventSender : [Attachment 87740] fix patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 09:07:29 PDT 2011


Chang Shu <cshu at webkit.org> has asked  for review:
Bug 57515: [Mac] [WK2] Implement KeyDown function for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=57515

Attachment 87740: fix patch
https://bugs.webkit.org/attachment.cgi?id=87740&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
This patch does the following things for KeyDown event:
1. passes function calls from WebKitTestRunner::InjectedBundle to
WebKit2::WebProcess::InjectedBundle through WK interface 
2. encodes it as a binary buffer attached to a general InjectedBundle message.
3. sends out the message to UIProcess
4. UIProcess passes the general InjectedBundle message to
WebKitTestRunner::EventSenderProxy.
5. EventSenderProxy calls the decoding mechanism through WK interface
5. EventSenderProxy further calls the platform-dependent code to trigger the
event from the UIProcess side.

Note that the platform-dependent implementation on Mac has not been done yet
for my lack of experience on objC development.


More information about the webkit-reviews mailing list