[webkit-reviews] review granted: [Bug 57336] experiment with moving caret by word in visual order : [Attachment 87718] patch w/ layout test

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 57336: experiment with moving caret by word in visual order
https://bugs.webkit.org/show_bug.cgi?id=57336

Attachment 87718: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=87718&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87718&action=review

> Source/WebCore/editing/visible_units.cpp:1163
> +    // FIXME: handle multi-spaces. Please refer bug
https://bugs.webkit.org/show_bug.cgi?id=57543 for detail.

Just say "FIXME: handle multi-spaces (https://webkit.org/b/57543)".

> Source/WebCore/editing/visible_units.cpp:1166
> +    if (previousWordBreak != wordBreak) {

Let's do early exit here instead.

> Source/WebCore/editing/visible_units.cpp:1170
> +	   if (boxContainingPreviousWordBreak == box)
> +	       return wordBreak;

Ditto. do:
if (boxContainingPreviousWordBreak != box)
    return VisiblePosition();
return wordBreak;

> Source/WebCore/editing/visible_units.cpp:1197
> +	   // FIXME: "else" not implemented yet.

FIXME: Implement the "else" case.

> Source/WebCore/editing/visible_units.cpp:1211
> +	   // FIXME: "else" not implemented yet.

Ditto.