[webkit-reviews] review granted: [Bug 40239] [Qt] ChromeClientQt.h has coding-style errors : [Attachment 87717] New patch to fix ChromeClientQt.h style issues

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Nancy Piedra
<nancy.piedra at nokia.com>'s request for review:
Bug 40239: [Qt] ChromeClientQt.h has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40239

Attachment 87717: New patch to fix ChromeClientQt.h style issues
https://bugs.webkit.org/attachment.cgi?id=87717&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87717&action=review

Looks good. Just check the namespace question before pushing.

> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h:113
> +    virtual WebCore::KeyboardUIMode keyboardUIMode();

Is the WebCore namespace needed here?