[webkit-reviews] review granted: [Bug 56906] CSS related SVG*Element changes doesn't require relayout : [Attachment 87680] Proposed patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 56906: CSS related SVG*Element changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=56906

Attachment 87680: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=87680&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87680&action=review

r=me  but with further comments to your LayoutTests, please fix the issues of
my last comment as well as this one and you can land the patch. great work!

>
LayoutTests/svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-inheri
t-lighting-color-css-prop.js:17
> +var gradientElement = createSVGElement("feDiffuseLighting");

gradientElement should be feDiffuseLightingElement

>
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-inher
it-lighting-color-css-prop.js:47
> +var rectElement = createSVGElement("image");

s/rectElement/imageElement/

>
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-light
ing-color-css-prop.js:46
> +var rectElement = createSVGElement("image");

s/rectElement/imageElement/