[webkit-reviews] review granted: [Bug 50961] <title> should support dir attribute : [Attachment 87687] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Evan Martin <evan at chromium.org>'s
request for review:
Bug 50961: <title> should support dir attribute
https://bugs.webkit.org/show_bug.cgi?id=50961

Attachment 87687: Patch
https://bugs.webkit.org/attachment.cgi?id=87687&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87687&action=review

This looks good to me.	I suspect WebKit-level folks may have opinions.  You
should consider emailing webkit-dev once this lands and encouraging
WebKit-level hackers to respect title directionality on their ports.

> Source/WebCore/html/HTMLTitleElement.cpp:84
> +    if (RenderStyle* style = computedStyle())
> +	   direction = style->direction();
> +    else if (RefPtr<RenderStyle> style = styleForRenderer())
> +	   direction = style->direction();

Sad that we don't have a reliable way to get a style, always.  (Not your fault
of course).