[webkit-reviews] review granted: [Bug 57466] Web Inspector: provide front-end wrappers for DOMAgent.querySelector[All]() that take care of fetching the document : [Attachment 87549] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 57466: Web Inspector: provide front-end wrappers for
DOMAgent.querySelector[All]() that take care of fetching the document
https://bugs.webkit.org/show_bug.cgi?id=57466

Attachment 87549: patch
https://bugs.webkit.org/attachment.cgi?id=87549&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87549&action=review

> Source/WebCore/inspector/front-end/AuditRules.js:675
> +		   console.error("Failed to get image style");

When does this happen?

> Source/WebCore/inspector/front-end/AuditRules.js:731
> +		   console.error("Failed to get styles");

ditto

> Source/WebCore/inspector/front-end/DOMAgent.js:363
> +	       requestArguments.push(callbackWrapper);

do you want to do this only in the success branch of onDocumentAvailable?

> Source/WebCore/inspector/front-end/DOMAgent.js:495
> +	       DOMAgent.querySelector(nodeId || this._document.id, selectors,
documentWide, wrappedCallback);

So 0 is still valid? I thought we agreed on not allowing it here.