[webkit-reviews] review granted: [Bug 57478] REGRESSION (r82400): Leaks seen beneath CSSParser::createFloatingVectorSelector when parsing UA stylesheet : [Attachment 87665] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 57478: REGRESSION (r82400): Leaks seen beneath
CSSParser::createFloatingVectorSelector when parsing UA stylesheet
https://bugs.webkit.org/show_bug.cgi?id=57478

Attachment 87665: Patch
https://bugs.webkit.org/attachment.cgi?id=87665&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87665&action=review

> Source/WebCore/css/CSSGrammar.y:1152
> +	       OwnPtr<Vector<OwnPtr<CSSParserSelector> > > selectorVector =
p->sinkFloatingSelectorVector($4);
> +	       $$->adoptSelectorVector(*selectorVector.get());

No need for the local variable, or the .get().

> Source/WebCore/css/CSSParser.h:188
>	   Vector<OwnPtr<CSSParserSelector> >* createFloatingSelectorVector();

Seems like we should change createFloatingSelectorVector to return a PassOwnPtr
at some point.