[webkit-reviews] review granted: [Bug 45072] PreloadScanner doesn't find image while executing script in head : [Attachment 87351] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 20:29:42 PDT 2011


Antti Koivisto <koivisto at iki.fi> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 45072: PreloadScanner doesn't find image while executing script in head
https://bugs.webkit.org/show_bug.cgi?id=45072

Attachment 87351: Patch
https://bugs.webkit.org/attachment.cgi?id=87351&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Ok, sounds convincing, r=me.

It might be better if you left HTMLPreloadScanner::scanningBody() and the
related tracking code still in. It can be removed later when we are sure it has
no value in mobile world either.

You can just do UNUSED_PARAM(referencedFromBody) with a FIXME in
CachedResourceLoader::preload().


More information about the webkit-reviews mailing list