[webkit-reviews] review granted: [Bug 57521] Move coordinate-computing logic into MouseRelatedEvent. : [Attachment 87658] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 19:47:49 PDT 2011


Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 57521: Move coordinate-computing logic into MouseRelatedEvent.
https://bugs.webkit.org/show_bug.cgi?id=57521

Attachment 87658: Patch
https://bugs.webkit.org/attachment.cgi?id=87658&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Generally speaking my goal was to have the events be simple data holders and
keep the smarts in the class to a minimum. Since the DOM allows you to create
events with arbitrary values, I figured the smarts of computing the arguments
for an event to send didn’t belong in the event class itself. There had to be
some exceptions, but my goal was to keep them to a minimum. Your patch heads in
the other direction.

I think it’s OK to have this logic in the event class.

I also think it’s dangerous to change the meanings of the MouseRelatedEvent
arguments. Before the constructor arguments and the init function arguments
were exactly the same thing.

Despite those reservations this change seems OK. But not a great bell-ringer of
an improvement.


More information about the webkit-reviews mailing list