[webkit-reviews] review granted: [Bug 57518] Clean up the sandbox parameter code : [Attachment 87653] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 57518: Clean up the sandbox parameter code
https://bugs.webkit.org/show_bug.cgi?id=57518

Attachment 87653: Patch
https://bugs.webkit.org/attachment.cgi?id=87653&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87653&action=review

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:153
> +static void appendReadonlySandboxDirectory(Vector<const char*>& vector,
const char* name, const String& path)
> +{
> +    appendSandboxParameterPathInternal(vector, name, [(NSString *)path
fileSystemRepresentation]);
> +}
> +
> +static void appendReadwriteSandboxDirectory(Vector<const char*>& vector,
const char* name, const String& path)
> +{
> +    appendSandboxParameterPathInternal(vector, name, [(NSString *)path
fileSystemRepresentation]);
> +}

These should take NSStrings.