[webkit-reviews] review denied: [Bug 57493] Update fast/canvas tests to avoid dumping the render tree when possible : [Attachment 87610] Patch

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 57493: Update fast/canvas tests to avoid dumping the render tree when
possible
https://bugs.webkit.org/show_bug.cgi?id=57493

Attachment 87610: Patch
https://bugs.webkit.org/attachment.cgi?id=87610&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87610&action=review

I see why you're trying to do this - to avoid differences in the expected
results for the different versions. But that makes many of the expected results
blank. How do you know if the test passed or failed? Normally you write
something to the page to says this which gets put into the expected results.

> LayoutTests/fast/canvas/canvas-transform-identity-expected.txt:1
> +

I understand the motivation of getting rid of the tree. But shouldn't you at
least put in pass/fail messages? What is this test doing? How do you know
whether it passed or not? The same is true for results on several other tests
here.