[webkit-reviews] review granted: [Bug 54403] Should turn off frame pointer omission (FPO) for Release (not Production) builds : [Attachment 87633] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 54403: Should turn off frame pointer omission (FPO) for Release (not
Production) builds
https://bugs.webkit.org/show_bug.cgi?id=54403

Attachment 87633: Patch
https://bugs.webkit.org/attachment.cgi?id=87633&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87633&action=review

> WebKitLibraries/win/tools/vsprops/release.vsprops:10
> +		AdditionalOptions="/Oy-"
> +		OmitFramePointers="false"

I think you should add a comment in the ChangeLog about why both of these are
being set.