[webkit-reviews] review granted: [Bug 48512] [GTK] Implement sample browser app for WebKit2 : [Attachment 87511] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 48512: [GTK] Implement sample browser app for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48512

Attachment 87511: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=87511&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87511&action=review

> Tools/MiniBrowser/gtk/main.c:133
> +    const gchar *uri = argc > 1 ? argv[1] : "http://www.webkitgtk.org/";
> +    gchar *fileURL = filenameToURL(uri);
> +
> +    WKPageLoadURL(WKViewGetPage(webView), WKURLCreateWithURL(fileURL));
> +    g_free(fileURL);

Please change this to be (including changing the name of filenameToURL to
argumentToURL):

gchar* url = argumentToURL(argc > 1 ? argv[1] : "http://www.webkitgtk.org/");
WKPageLoadURL(WKViewGetPage(webView), WKURLCreateWithURL(url));
g_free(url);

We do not necessarily know if the argument is a path or a URL or whether the
result is a file or web URL.